Page 1 of 1

Re: Code issues

Posted: Wed Jun 09, 2010 6:54 am
by YamiKaitou
turbu wrote:Hello.
build: 556.
File cvar.inl twice registering cvar wc3_bot_buy_item:

Code: Select all

// Bot CVARs
CVAR_wc3_bot_buy_item	= register_cvar( "wc3_bot_buy_item"	, "0.33" );
CVAR_wc3_bot_buy_item	= register_cvar( "wc3_bot_buy_item"	, "0.33" );
I think one line is removed :)
Fixed
FInd in war3ft/db/db_mysql.inl:

Code: Select all

"CREATE TABLE IF NOT EXISTS `wc3_web_race` ( `race_id` tinyint(4) unsigned NOT NULL default '0', `race_lang` char(2) NOT NULL default '', `race_name` varchar(100) default NULL, `race_description` text NOT NULL, PRIMARY KEY  (`race_id`,`race_lang`) ) TYPE=MyISAM;",
"CREATE TABLE IF NOT EXISTS `wc3_web_skill` ( `skill_id` tinyint(4) unsigned NOT NULL default '0', `skill_lang` char(2) NOT NULL default '', `skill_name` varchar(100) default NULL, `skill_description` text NOT NULL, `skill_type` tinyint(4) unsigned NOT NULL default '0', `skill_owner` tinyint(4) unsigned NOT NULL default '0', PRIMARY KEY  (`skill_id`,`skill_lang`) ) TYPE=MyISAM;",
Replace:

Code: Select all

"CREATE TABLE IF NOT EXISTS `wc3_web_race` ( `race_id` tinyint(4) unsigned NOT NULL default '0', `race_lang` char(2) NOT NULL default '', `race_name` varchar(100) default NULL, `race_description` mediumtext NOT NULL, PRIMARY KEY  (`race_id`,`race_lang`) ) TYPE=MyISAM;",
"CREATE TABLE IF NOT EXISTS `wc3_web_skill` ( `skill_id` tinyint(4) unsigned NOT NULL default '0', `skill_lang` char(2) NOT NULL default '', `skill_name` varchar(100) default NULL, `skill_description` mediumtext NOT NULL, `skill_type` tinyint(4) unsigned NOT NULL default '0', `skill_owner` tinyint(4) unsigned NOT NULL default '0', PRIMARY KEY  (`skill_id`,`skill_lang`) ) TYPE=MyISAM;",
Changed text field for mediumtext.
Why? Doing this means that I then have to alter the table for everyone else and that just isn't going to happen unless I change the entire DB layout