|
Title: Update the category "changerace" menu to include an "all races" entry Post by: Remy Lebeau on December 27, 2012, 04:36:01 PM So we talked about this a bit in another thread, but I figured I'd make a specific request thread for it.
I haven't yet worked with menu's enough to work out how to do this. Can someone please modify the changerace category menu to include an "All Races" entry (which is sorted according to the war3source.cfg order listing)? That would mean that I can enable the category listing, and people can still see the race order listed by required XP (which is how we sort it). Thanks! ps. an even more advanced system would be to also allow players to create a custom list of their personal favorite races for quick access. Title: Re: Update the category "changerace" menu to include an "all races" entry Post by: Revan on December 27, 2012, 04:43:05 PM yes, that sounds cool.
I'll try to implement theese should the "All Races" entry listed just before the other? All Races Human Undeads Title: Re: Update the category "changerace" menu to include an "all races" entry Post by: Remy Lebeau on December 27, 2012, 05:36:11 PM I think that'd be great! So 1 is always "all races" - so ppl who want to go straight to the all races menu can do it quickly
Title: Re: Update the category "changerace" menu to include an "all races" entry Post by: Revan on December 29, 2012, 06:10:28 AM I've pushed a update to the master, All Races entry added.
Title: Re: Update the category "changerace" menu to include an "all races" entry Post by: Remy Lebeau on December 29, 2012, 03:11:16 PM *hugs*
Title: Re: Update the category "changerace" menu to include an "all races" entry Post by: Remy Lebeau on December 31, 2012, 08:22:46 PM I've just done some further testing with this update (or at least whatever version is the latest on github war3source 2.0)
I have found the following bugs: 1) The all races menu is empty! The other menus all populate as normal, but instead of all races being in the all races menu, none are :( 2) Whenever I press the last option (to go back up a level in the menu), I see the following error in console: Code: .sp::OnW3Denyable() L 01/01/2013 - 13:20:25: [SM] Plugin encountered error 25: Call was aborted L 01/01/2013 - 13:20:25: [SM] Native "ThrowError" reported: DN_CanSelectRace CA LLED WITH INVALID RACE [-1] L 01/01/2013 - 13:20:25: [SM] Displaying call stack trace for plugin "w3s\War3So urce_Engine_RaceRestrictions.smx": L 01/01/2013 - 13:20:25: [SM] [0] Line 26, War3Source_Engine_RaceRestrictions .sp::OnW3Denyable() L 01/01/2013 - 13:20:27: [SM] Plugin encountered error 25: Call was aborted L 01/01/2013 - 13:20:27: [SM] Native "ThrowError" reported: DN_CanSelectRace CA LLED WITH INVALID RACE [-1] L 01/01/2013 - 13:20:27: [SM] Displaying call stack trace for plugin "w3s\War3So urce_Engine_RaceRestrictions.smx": L 01/01/2013 - 13:20:27: [SM] [0] Line 26, War3Source_Engine_RaceRestrictions .sp::OnW3Denyable() L 01/01/2013 - 13:20:31: [SM] Plugin encountered error 25: Call was aborted L 01/01/2013 - 13:20:31: [SM] Native "ThrowError" reported: DN_CanSelectRace CA LLED WITH INVALID RACE [-1] L 01/01/2013 - 13:20:31: [SM] Displaying call stack trace for plugin "w3s\War3So urce_Engine_RaceRestrictions.smx": L 01/01/2013 - 13:20:31: [SM] [0] Line 26, War3Source_Engine_RaceRestrictions .sp::OnW3Denyable() Title: Re: Update the category "changerace" menu to include an "all races" entry Post by: Ownz on December 31, 2012, 08:34:14 PM these guys need some better quality control :P
Title: Re: Update the category "changerace" menu to include an "all races" entry Post by: Gliderā ā µ on December 31, 2012, 08:50:26 PM check the issue tracker before posting :) (https://github.com/War3Source/War3Source/issues/2)
Revan only fixed the issue for the main repository. It hasn't been merged into War3Source-2 yet. Title: Re: Update the category "changerace" menu to include an "all races" entry Post by: Remy Lebeau on December 31, 2012, 09:14:28 PM So enough of us are using git now that I should just use it's bug tracking to report bugs rather than forums?
Title: Re: Update the category "changerace" menu to include an "all races" entry Post by: Necavi on December 31, 2012, 09:15:30 PM Ownz: Not to mention what Glider said, War3Source 2.0 is considered "alpha" pretty much, bugs are expected as things are restructured. We'll most likely be able to keep everything working as we are modifying things, but that isn't considered to be a complete necessity, especially for larger changes.
Remy: Using the bugtracker will get the most support from a lot of us, really. |