Archived copy of war3source.com, the War3Source forum (2009–2020), rebuilt from the Internet Archive by wc3mods.net. This page was captured on 2012-10-24 (original capture). Forum · All archived topics · Wiki · Bug tracker · Blog
Chat

War3:Source
October 24, 2012, 10:45:52 AM *
Welcome, Guest. Please login or register.
Did you miss your activation email?

Login with username, password and session length
News: Download: http://war3source.com/index.php?board=9.0
What is War3Source?: http://war3source.com/index.php?topic=200.0
Sample Stats: http://war3source.com/war3stats
Steam Community Group: http://steamcommunity.com/groups/war3source
War3Source SVN Checkout: http://ownageclan.com/svn/war3source/
War3Source servers: http://www.game-monitor.com/search.php?vars=war3_version=
 
   Home   Help Search Login Register  
Pages: [1]
  Print  
Author Topic: Crypt Lord's Spiked Carapace skill  (Read 282 times)
Naris
Jr. Member
**
Posts: 60


View Profile Email
« on: June 08, 2010, 05:59:06 PM »

I have had a reports that the Crypt Lord's Spiked Carapace skill apparently doesn't actually reduce damage very often (this is in TF2). http://jigglysfunhouse.net/thebuggenie/viewissue.php?issue_no=67

Looking at the code, the way it uses the chance modifier looks suspect for those times when it is not 1.0. In those cases it will only rarely block any damage  Undecided

I also noticed that even though it places the max health in the maxhp variable, it then calls War3_GetMaxHP(victim) 2 more times when it should probably just use maxhp.

Code:
new currenthp=GetClientHealth(victim);
new maxhp=War3_GetMaxHP(victim);
if(currenthp<maxhp)
{
new newhp=currenthp+RoundFloat(damage*SpikeArr[skill_level]);
if(newhp>War3_GetMaxHP(victim))
{
newhp=War3_GetMaxHP(victim);
}
SetEntityHealth(victim,newhp);
}
« Last Edit: June 08, 2010, 06:01:04 PM by Naris » Logged
Ownz
Developer
Administrator
Hero Member
*****
Posts: 2045



View Profile WWW Email
« Reply #1 on: June 08, 2010, 06:24:48 PM »

self damage is not reduced
Logged

DarkEnergy
Naris
Jr. Member
**
Posts: 60


View Profile Email
« Reply #2 on: June 08, 2010, 08:32:43 PM »

self damage is not reduced

Doh!  Embarrassed  I should of known that...
Logged
Pages: [1]
  Print  
 
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.11 | SMF © 2006-2009, Simple Machines LLC Valid XHTML 1.0! Valid CSS!