Archived copy of war3source.com, the War3Source forum (2009–2020), rebuilt from the Internet Archive by wc3mods.net. This page was captured on 2013-01-25 (original capture). Forum · All archived topics · Wiki · Bug tracker · Blog
Chat

War3:Source
January 24, 2013, 10:44:38 PM *
Welcome, Guest. Please login or register.
Did you miss your activation email?

Login with username, password and session length
News: Download: http://war3source.com/index.php?board=9.0
What is War3Source?: http://war3source.com/index.php?topic=200.0
Sample Stats: http://war3source.com/war3stats
Steam Community Group: http://steamcommunity.com/groups/war3source
War3Source SVN Checkout: http://ownageclan.com/svn/war3source/
War3Source servers: http://www.game-monitor.com/search.php?vars=war3_version=
 
   Home   Help Search Login Register  
Pages: [1]
  Print  
Author Topic: Spring Cleaning  (Read 172 times)
Necavi
Sr. Member
****
Posts: 297


View Profile
« on: December 29, 2012, 08:56:55 PM »

Again as suggested by Glider, I would like to start some spring cleaning, possible topics for this cleaning involve:
- Updating everything to use the new styleguide
- Removing or implementing (or simply adding issues regarding them so that we can implement them easily later) all outstanding partially implemented features
- Anything else that may come up (please add more in comments below)
- Split up War3Source_Interface; remove unused interface items (likely any remaining deprecated ones as well)
- Remove all MarkNativeAsOptionals, as ownz has convinced me that any hope of being able to reload war3source is pointless, so adding a large amount of filesize and longer start time is rather useless
« Last Edit: December 29, 2012, 10:06:15 PM by Necavi » Logged

Glider⠠⠵
Global Moderator
Sr. Member
*****
Posts: 454


⠠⠵


View Profile
« Reply #1 on: December 29, 2012, 09:53:04 PM »

See which includes are actually used and remove those that are not in use. Also splitting up the remaining things into more sensible includes. Right now the War3Source Interface is one big mess. I think the Interface itself should simply include all the other includes and that's it. Also I'm really fond of my L4D interface and I think every game should have their own specific include to dump methods for that game into. I already have my own private interface for tf2 for some things like getting/setting the uber level of a medic and stuff that others could benefit from.
Logged

Necavi
Sr. Member
****
Posts: 297


View Profile
« Reply #2 on: December 29, 2012, 10:06:34 PM »

Added to the list
Logged

Ownz
Developer
Administrator
Hero Member
*****
Posts: 2169



View Profile WWW
« Reply #3 on: December 29, 2012, 10:27:36 PM »

go ahead and split the .inc

has anyone found anything that has auto-completion that is not the crashy pawnstudio?
Logged

DarkEnergy
Necavi
Sr. Member
****
Posts: 297


View Profile
« Reply #4 on: December 29, 2012, 10:31:26 PM »

Not anything decent, unfortunately.
Logged

Glider⠠⠵
Global Moderator
Sr. Member
*****
Posts: 454


⠠⠵


View Profile
« Reply #5 on: December 29, 2012, 10:32:48 PM »

Sadly, no.

Also I think we should take this opportunity of switching to git to really clean house and refactor all the mess we got in the codebase. Since we always strived for compatibility there's a lot of deprecated mess around that we should finally wipe out. Release a final stable version and then work on War3Source 2.0 without all the mess  Grin
Logged

Ownz
Developer
Administrator
Hero Member
*****
Posts: 2169



View Profile WWW
« Reply #6 on: December 29, 2012, 10:33:01 PM »

FACT: everything was in one single .inc file was due to the fact pawnstudio didnt recursively parse include files


put all the changes from the current latest svn to your git

i will try to redirect http://ownageclan.com/war3source/functionreference/ to use git
Logged

DarkEnergy
Glider⠠⠵
Global Moderator
Sr. Member
*****
Posts: 454


⠠⠵


View Profile
« Reply #7 on: December 30, 2012, 01:22:43 PM »

Do we still need War3Source_ESCompatLayer.sp? Did anybody ever use it?

Also if you look into War3Source.sp you'll find this:

Code:
#define VERSION_NUM "1.2.4.0"
#define REVISION_NUM 12400 //increment every release
//ownz: im not going to bother updating this every time, i can't tell what the next rev is. revision_num was intended for this purpose
#define REVISION_SVN "855" //Add 1 to the number of the current SVN before you commit

Can we please change the build process to autogenerate this? Use jenkins build number for the revision and include the branch from git.

Also Necavi do you mind granting me the necessary rights to Jenkins so I can look at/adjust the build scripts?
« Last Edit: December 30, 2012, 02:06:09 PM by Glider⠠⠵ » Logged

Necavi
Sr. Member
****
Posts: 297


View Profile
« Reply #8 on: December 30, 2012, 03:44:06 PM »

Unfortunately the build scripts are inaccessible from jenkins, but I can send them to you anyway
Logged

Ownz
Developer
Administrator
Hero Member
*****
Posts: 2169



View Profile WWW
« Reply #9 on: December 30, 2012, 06:54:44 PM »

War3Source_ESCompatLayer.sp was anthony's idea. I told him it wasnt worth his time but he tried anyway.
Logged

DarkEnergy
Glider⠠⠵
Global Moderator
Sr. Member
*****
Posts: 454


⠠⠵


View Profile
« Reply #10 on: December 30, 2012, 07:16:09 PM »

Another thing: I really despise cryptic skills where you're not sure what they do. I often get asked by players on the server and then have to dig up the source code to the race to give them the values, that's why I prefer writing the exact benefits of a skill into the description like "Increases your speed by 5/10/15/20%". I'd really like it if we'd change the translation files for this. Only problem will be the key value interface. We'd need to return the right values even if they were changed in the config Wink
« Last Edit: December 30, 2012, 07:18:28 PM by Glider⠠⠵ » Logged

Ownz
Developer
Administrator
Hero Member
*****
Posts: 2169



View Profile WWW
« Reply #11 on: December 30, 2012, 07:26:10 PM »

there is currently a system where on registration of the skill, you pass a string argument for 5% 10% stuff
Logged

DarkEnergy
Necavi
Sr. Member
****
Posts: 297


View Profile
« Reply #12 on: December 30, 2012, 07:41:53 PM »

I was thinking of adding a "lore description" and a "real description"
Logged

Pages: [1]
  Print  
 
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.11 | SMF © 2006-2009, Simple Machines LLC Valid XHTML 1.0! Valid CSS!