War3:Source

Hi guys,

With some races that have a higher MaxHP, occasionally they will spawn with the maximum HP, instead of the standard spawn HP.

To explain further, a race Boyscout.  This is designed to spawn on 100HP, but through the use of ultimate, you can increase the health (up to a maximum of 250).

Lately, we've been seeing this race spawn with the 250 health, rather than the 100.

It's not just this race though, it appears to be any race that has a higher MaxHP than standard spawn amount can potentially be spawned with their max HP.

Just want to know if anyone else has come across this issue?  Or is there a fix in the pipeline for it?

Cheers

Could you post the Scout race for us to see? If it is private you can send it to me in a PM.

The race is a modified version of the original Boy Scout written by xDr.HaaaaaaaXx, and while I don't know if our senior dev wants the source released, this is every call to a HP buff or heal shown in context:

public InitPassiveSkills( client )
{
    //Called when race is changed to, skill level is changed, or race spawns
    if( War3_GetRace( client ) == thisRaceID )
    {           
        ...
       
        War3_SetBuff(client, iAdditionalMaxHealthNoHPChange, thisRaceID, bsmaximumHP);
       
        ...
    }
}

public OnUltimateCommand( client, race, bool:pressed )
{
    if( race == thisRaceID && pressed && IsPlayerAlive( client ) && !Silenced( client ) )
    {
        new ult_level = War3_GetSkillLevel( client, race, ULT_AID );
        if( ult_level > 0 )
        {
            if( War3_SkillNotInCooldown( client, thisRaceID, ULT_AID, true ) )
            {
                ...
           
                War3_HealToMaxHP(client, HP[ult_level]);
               
                ...
            }
        }
        else
        {
            W3MsgUltNotLeveled( client );
        }
    }
}

There's a similar trend in the other affected races on our server. I'll be checking every race on our server which uses the NoHPChange buff soon to see if it's one of them, but since I'm not aware of a pattern to the occurrences it's difficult to tell if it's our plugins or the core. That's why we want to see if anyone else has been experiencing a similar issue to get a better idea of where to look for the problem

iAdditionalMaxHealthNoHPChange so they shouldn't spawn with maxed out health

your code doesn't show where it resets the buff if player changes race or leaves, and is InitPassiveSkills always called, and is skill level check always used?

or just unload the race and see if this happens without the race

The race is a modified version of the original Boy Scout written by xDr.HaaaaaaaXx, and while I don't know if our senior dev wants the source released, this is every call to a HP buff or heal shown in context:

Code: [Select]

public InitPassiveSkills( client )
{
    //Called when race is changed to, skill level is changed, or race spawns
    if( War3_GetRace( client ) == thisRaceID )
    {           
        ...
       
        War3_SetBuff(client, iAdditionalMaxHealthNoHPChange, thisRaceID, bsmaximumHP);
       
        ...
    }
}

public OnUltimateCommand( client, race, bool:pressed )
{
    if( race == thisRaceID && pressed && IsPlayerAlive( client ) && !Silenced( client ) )
    {
        new ult_level = War3_GetSkillLevel( client, race, ULT_AID );
        if( ult_level > 0 )
        {
            if( War3_SkillNotInCooldown( client, thisRaceID, ULT_AID, true ) )
            {
                ...
           
                War3_HealToMaxHP(client, HP[ult_level]);
               
                ...
            }
        }
        else
        {
            W3MsgUltNotLeveled( client );
        }
    }
}

There's a similar trend in the other affected races on our server. I'll be checking every race on our server which uses the NoHPChange buff soon to see if it's one of them, but since I'm not aware of a pattern to the occurrences it's difficult to tell if it's our plugins or the core. That's why we want to see if anyone else has been experiencing a similar issue to get a better idea of where to look for the problem

I don't mind if you need to post up our full source for boyscout.  Dr Haaax might though

Quote from: Remy Lebeau on December 14, 2015, 04:54:49 PM

I don't mind if you need to post up our full source for boyscout.  Dr Haaax might though

You can get Boy Scout here

Kibbs was referring to our modified version

You're right though, since boyscout is public, I don't see it being a problem to share ours.