Add MAX_NAME_LENGTH constants to w3s interface

War3:Source > General Discussion > War3: Source - Requests > Add MAX_NAME_LENGTH constants to w3s interface

Pages: [1]

« previous next »

Author

Topic: Add MAX_NAME_LENGTH constants to w3s interface (Read 374 times)

Frenzzy

Full Member

Posts: 217

Add MAX_NAME_LENGTH constants to w3s interface

« on: June 06, 2011, 05:29:52 PM »

Please add MAX_NAME_LENGTH constants to w3s interface.
I think it will help to make fewer errors in addons.
Examples:

#define MAX_RACE_SHORTNAME 32
#define MAX_RACE_FULLNAME 64

#define MAX_ITEM_SHORTNAME 32
#define MAX_ITEM_FULLNAME 64

..and ect.


	Logged

O_o

Ownz

Developer
Administrator
Hero Member

Posts: 2046

Re: Add MAX_NAME_LENGTH constants to w3s interface

« Reply #1 on: June 06, 2011, 05:57:50 PM »

shortname should be only 16


	Logged

DarkEnergy

Frenzzy

Full Member

Posts: 217

Re: Add MAX_NAME_LENGTH constants to w3s interface

« Reply #2 on: June 06, 2011, 06:17:46 PM »

This is just an example. I want to use this constants and not think about the max length of names :о)


	Logged

O_o

Glider⠠⠵

Global Moderator
Sr. Member

Posts: 413

⠠⠵

Re: Add MAX_NAME_LENGTH constants to w3s interface

« Reply #3 on: June 06, 2011, 09:06:41 PM »

Code:

public NWar3_CreateNewRace(Handle:plugin,numParams){

decl String:name[64],String:shortname[16];
GetNativeString(1,name,sizeof(name));
GetNativeString(2,shortname,sizeof(shortname));

//W3Log("add race %s %s",name,shortname);

return CreateNewRace(name,shortname);

}

What actually happens when you pass something that is larger than 16/64 characters? Does it actually throw an error or does it just cut up the string? If there's no error then I suggest adding the constants and throwing a real error.

Also what the heck are your races called if your shortnames are longer than 16 characters Cheesy


	Logged

Ownz

Developer
Administrator
Hero Member

Posts: 2046

Re: Add MAX_NAME_LENGTH constants to w3s interface

« Reply #4 on: June 06, 2011, 09:11:07 PM »

it gets truncated


	Logged

DarkEnergy

Pages: [1]

« previous next »

Jump to: